Skip to content

Commit

Permalink
remove fallthrough
Browse files Browse the repository at this point in the history
  • Loading branch information
poopoothegorilla committed Feb 14, 2024
1 parent 4c1e539 commit 7cf05c9
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions common/txmgr/confirmer.go
Original file line number Diff line number Diff line change
Expand Up @@ -868,13 +868,9 @@ func (ec *Confirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) han
// If there is only one RPC node, or all RPC nodes have the same
// configured cap, this transaction will get stuck and keep repeating
// forever until the issue is resolved.
if len(etx.TxAttempts) <= 1 {
lggr.Criticalw(`RPC node rejected this tx as outside Fee Cap but it implies that it was successful on another node previously`, "attempt", attempt)
timeout := ec.dbConfig.DefaultQueryTimeout()
return ec.txStore.SaveSentAttempt(ctx, timeout, &attempt, now)
}

fallthrough
lggr.Criticalw(`RPC node rejected this tx as outside Fee Cap but it implies that it was successful on another node previously`, "attempt", attempt)
timeout := ec.dbConfig.DefaultQueryTimeout()
return ec.txStore.SaveSentAttempt(ctx, timeout, &attempt, now)
case client.Fatal:
// WARNING: This should never happen!
// Should NEVER be fatal this is an invariant violation. The
Expand Down

0 comments on commit 7cf05c9

Please sign in to comment.