adjust timing to fix flake

smartcontractkit · Jun 14, 2024 · 990b571 · 990b571
1 parent efb2b18
commit 990b571
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/services/relay/evm/chain_reader_test.go b/core/services/relay/evm/chain_reader_test.go
@@ -87,8 +87,8 @@ func (h *helper) Context(t *testing.T) context.Context {
 }
 
 func (h *helper) MaxWaitTimeForEvents() time.Duration {
-	// From trial and error, when running on CI, sometimes the boxes get slow
-	maxWaitTime := time.Second * 30
+	// There are no scheduling guarantees in a busy CI test suite. 30s was failing frequently.
+	maxWaitTime := 10 * time.Minute
 	maxWaitTimeStr, ok := os.LookupEnv("MAX_WAIT_TIME_FOR_EVENTS_S")
 	if ok {
 		waitS, err := strconv.ParseInt(maxWaitTimeStr, 10, 64)

diff --git a/core/services/relay/evm/evmtesting/run_tests.go b/core/services/relay/evm/evmtesting/run_tests.go
@@ -39,7 +39,7 @@ func RunChainReaderEvmTests[T TestingT[T]](t T, it *EVMChainReaderInterfaceTeste
 
 		require.Eventually(t, func() bool {
 			return cr.GetLatestValue(ctx, AnyContractName, triggerWithDynamicTopic, input, output) == nil
-		}, it.MaxWaitTimeForEvents(), time.Millisecond*10)
+		}, it.MaxWaitTimeForEvents(), 100*time.Millisecond)
 
 		assert.Equal(t, &anyString, rOutput.FieldByName("Field").Interface())
 		topic, err := abi.MakeTopics([]any{anyString})