Skip to content

Commit

Permalink
removing workflow execution id label from engine metrics (#14997)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhuie19 authored Oct 29, 2024
1 parent 5b66644 commit 9a0fd34
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/services/workflows/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ func (e *Engine) registerTrigger(ctx context.Context, t *triggerCapability, trig
}
eventsCh, err := t.trigger.RegisterTrigger(ctx, triggerRegRequest)
if err != nil {
e.metrics.with(cIDKey, t.ID, tIDKey, triggerID).incrementRegisterTriggerFailureCounter(ctx)
e.metrics.incrementRegisterTriggerFailureCounter(ctx)
// It's confusing that t.ID is different from triggerID, but
// t.ID is the capability ID, and triggerID is the trigger ID.
//
Expand Down Expand Up @@ -661,7 +661,7 @@ func (e *Engine) queueIfReady(state store.WorkflowExecution, step *step) {

func (e *Engine) finishExecution(ctx context.Context, executionID string, status string) error {
e.logger.With(eIDKey, executionID, "status", status).Info("finishing execution")
metrics := e.metrics.with(eIDKey, executionID, "status", status)
metrics := e.metrics.with("status", status)
err := e.executionStates.UpdateStatus(ctx, executionID, status)
if err != nil {
return err
Expand Down

0 comments on commit 9a0fd34

Please sign in to comment.