Skip to content

Commit

Permalink
Improve Testnet Notifications (#10681)
Browse files Browse the repository at this point in the history
* Improve Testnet Notifications

* Use cancelled()

* Better check
  • Loading branch information
kalverra authored Sep 18, 2023
1 parent 73966ef commit c8762ee
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ jobs:
MATRIX_JSON_KEEPER=$(./scripts/buildTestMatrixList.sh ./smoke/keeper_test.go keeper ubuntu20.04-8cores-32GB 1)
COMBINED_ARRAY=$(jq -c -n "$MATRIX_JSON_AUTOMATION + $MATRIX_JSON_KEEPER")
echo "MATRIX_JSON=${COMBINED_ARRAY}" >> $GITHUB_ENV
eth-smoke-tests-matrix-automation:
if: ${{ !contains(join(github.event.pull_request.labels.*.name, ' '), 'skip-smoke-tests') }}
environment: integration
Expand Down Expand Up @@ -235,6 +236,7 @@ jobs:
this-job-name: ETH Smoke Tests ${{ matrix.product.name }}
test-results-file: '{"testType":"go","filePath":"/tmp/gotest.log"}'
continue-on-error: true

eth-smoke-tests-matrix:
if: ${{ !contains(join(github.event.pull_request.labels.*.name, ' '), 'skip-smoke-tests') }}
environment: integration
Expand Down Expand Up @@ -805,7 +807,7 @@ jobs:

testnet-smoke-tests-notify:
name: Live Testnet Start Slack Thread
if: success() || failure()
if: ${{ needs.*.result != 'skipped' }}
environment: integration
outputs:
thread_ts: ${{ steps.slack.outputs.thread_ts }}
Expand Down Expand Up @@ -857,6 +859,7 @@ jobs:

testnet-smoke-tests-results:
name: Post Live Testnet Smoke Test Results
if: ${{ needs.*.result != 'skipped' }}
environment: integration
permissions:
checks: write
Expand Down

0 comments on commit c8762ee

Please sign in to comment.