Merge branch 'develop' into BCI-2919-Update-FinalityDepth-check-logic…

…-on-Head-Tracker
smartcontractkit · May 20, 2024 · e49ef69 · e49ef69
2 parents 1219f10 + 0d58a8d
commit e49ef69
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/.changeset/gorgeous-squids-laugh.md b/.changeset/gorgeous-squids-laugh.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+link transfer status check #bugfix
diff --git a/contracts/.changeset/smooth-years-reply.md b/contracts/.changeset/smooth-years-reply.md
@@ -0,0 +1,5 @@
+---
+"@chainlink/contracts": patch
+---
+
+link transfer status check #bugfix
diff --git a/contracts/src/v0.8/automation/dev/v2_3/AutomationRegistryLogicC2_3.sol b/contracts/src/v0.8/automation/dev/v2_3/AutomationRegistryLogicC2_3.sol
@@ -69,7 +69,7 @@ contract AutomationRegistryLogicC2_3 is AutomationRegistryBase2_3 {
   }
 
   /**
-   * @notice withdraws LINK received as payment for work performed
+   * @notice this is for NOPs to withdraw LINK received as payment for work performed
    */
   function withdrawPayment(address from, address to) external {
     if (to == ZERO_ADDRESS) revert InvalidRecipient();
@@ -78,7 +78,10 @@ contract AutomationRegistryLogicC2_3 is AutomationRegistryBase2_3 {
     uint96 balance = _updateTransmitterBalanceFromPool(from, s_hotVars.totalPremium, uint96(s_transmittersList.length));
     s_transmitters[from].balance = 0;
     s_reserveAmounts[IERC20(address(i_link))] = s_reserveAmounts[IERC20(address(i_link))] - balance;
-    i_link.transfer(to, balance);
+    bool transferStatus = i_link.transfer(to, balance);
+    if (!transferStatus) {
+      revert TransferFailed();
+    }
     emit PaymentWithdrawn(from, balance, to, msg.sender);
   }