Skip to content

Commit

Permalink
remove comments that are still referencing to finalityDepth within ev…
Browse files Browse the repository at this point in the history
…m/txmgr
  • Loading branch information
Farber98 committed Jul 4, 2024
1 parent 96d630f commit f27399a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions core/chains/evm/txmgr/evm_tx_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ import (

var (
ErrKeyNotUpdated = errors.New("evmTxStore: Key not updated")
// ErrCouldNotGetReceipt is the error string we save if we reach our finality depth for a confirmed transaction without ever getting a receipt
// This most likely happened because an external wallet used the account for this nonce
// ErrCouldNotGetReceipt is the error string we save if we reach our LatestFinalizedBlockNum for a confirmed transaction
// without ever getting a receipt. This most likely happened because an external wallet used the account for this nonce
ErrCouldNotGetReceipt = "could not get receipt"
)

Expand Down Expand Up @@ -960,11 +960,11 @@ func (o *evmTxStore) SaveFetchedReceipts(ctx context.Context, r []*evmtypes.Rece
// NOTE: We continue to attempt to resend evm.txes in this state on
// every head to guard against the extremely rare scenario of nonce gap due to
// reorg that excludes the transaction (from another wallet) that had this
// nonce (until finality depth is reached, after which we make the explicit
// nonce (until LatestFinalizedBlockNum is reached, after which we make the explicit
// decision to give up). This is done in the EthResender.
//
// We will continue to try to fetch a receipt for these attempts until all
// attempts are below the finality depth from current head.
// attempts are below the LatestFinalizedBlockNum from current head.
func (o *evmTxStore) MarkAllConfirmedMissingReceipt(ctx context.Context, chainID *big.Int) (err error) {
var cancel context.CancelFunc
ctx, cancel = o.stopCh.Ctx(ctx)
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/txmgr/reaper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func TestReaper_ReapTxes(t *testing.T) {

err = r.ReapTxes(42)
assert.NoError(t, err)
// Now it deleted because the eth_tx was past EVM.FinalityDepth
// Now it deleted because the eth_tx was marked as finalized
cltest.AssertCount(t, db, "evm.txes", 0)
})

Expand Down

0 comments on commit f27399a

Please sign in to comment.