Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.21.1 #10125

Merged
merged 3 commits into from
Sep 21, 2023
Merged

go 1.21.1 #10125

merged 3 commits into from
Sep 21, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 9, 2023 •
edited
Loading

Bumping Go to 1.21.1.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the go-1.21 branch 2 times, most recently from 6f084df to 8d27ae2 Compare August 14, 2023 22:57
@jmank88 jmank88 force-pushed the go-1.21 branch 3 times, most recently from 7ccbc52 to 6a40f49 Compare September 3, 2023 11:56
@jmank88
Copy link
Contributor Author

jmank88 commented Sep 3, 2023

The build is healthier after bumping pyroscope (#10463), but the 1.21-buster docker image still doesn't exist.

@jmank88 jmank88 force-pushed the go-1.21 branch 5 times, most recently from a1636cf to 5408889 Compare September 8, 2023 12:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6121657039

@jmank88 jmank88 requested a review from HenryNguyen5 September 8, 2023 12:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6121723882

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6122850285

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6133172309

@jmank88 jmank88 force-pushed the go-1.21 branch 3 times, most recently from 04ca52d to 6da7505 Compare September 18, 2023 11:50
@jmank88 jmank88 marked this pull request as ready for review September 18, 2023 12:49
@jmank88 jmank88 requested review from krehermann and a team as code owners September 18, 2023 12:49
@jmank88 jmank88 requested a review from a team September 18, 2023 12:49
krehermann
krehermann previously approved these changes Sep 18, 2023
View reviewed changes
@jmank88
Copy link
Contributor Author

jmank88 commented Sep 18, 2023 •
edited
Loading

package features in shard 2 is consistently failing, but there is a secondary failure hiding the original, and I haven't been able to reproduce locally 🤔

traceback did not unwind completely

@jmank88 jmank88 requested a review from samsondav as a code owner September 19, 2023 18:49
@jmank88 jmank88 requested a review from krehermann September 20, 2023 22:54
@jmank88 jmank88 changed the title go 1.21 go 1.21.1 Sep 20, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmank88 jmank88 requested review from a team and chainchad September 20, 2023 23:35
@jmank88 jmank88 requested review from a team September 21, 2023 17:53
@jmank88 jmank88 added this pull request to the merge queue Sep 21, 2023
Merged via the queue into develop with commit 175d70c Sep 21, 2023
82 checks passed
@jmank88 jmank88 deleted the go-1.21 branch September 21, 2023 20:05
mohamed-mehany added a commit that referenced this pull request Sep 28, 2023
@mohamed-mehany
Revert "go 1.21.1 (#10125)"
b06670a 
This reverts commit 175d70c. upgrade to
go 1.21.1 due to an issue introduced in go 1.21.1
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
@jmank88 jmank88 mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@HenryNguyen5 HenryNguyen5 Awaiting requested review from HenryNguyen5

@samsondav samsondav Awaiting requested review from samsondav

@krehermann krehermann Awaiting requested review from krehermann

@chainchad chainchad Awaiting requested review from chainchad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @vyzaldysanchez @krehermann @patrickhuie19