Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-2506] Fix: id instead of legacy evmChainId in errors verbatim #10314

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[BCF-2506] Fix: id instead of legacy evmChainId in errors verbatim #10314

merged 2 commits into from
Sep 14, 2023

Conversation

chudilka1
Copy link
Contributor

This is a fix for errors verbatim used for the chainlink txs evm create CLI command on the node running with a multi-chain setup: now verbatim requires to use id flag instead of the evmChainId flag.

@chudilka1 chudilka1 requested a review from jkongie as a code owner August 23, 2023 16:19
@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch 2 times, most recently from f0514aa to 6352ef6 Compare August 23, 2023 16:37
jmank88
jmank88 reviewed Aug 23, 2023
View reviewed changes
core/web/common.go Outdated Show resolved Hide resolved
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch from 6352ef6 to 0907c43 Compare August 28, 2023 15:47
jmank88
jmank88 previously approved these changes Aug 29, 2023
View reviewed changes
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch 3 times, most recently from 2091aa4 to af07727 Compare September 4, 2023 09:58
@jmank88 jmank88 enabled auto-merge September 5, 2023 19:45
jmank88
jmank88 previously approved these changes Sep 5, 2023
View reviewed changes
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch 2 times, most recently from c82b3ef to ead3473 Compare September 6, 2023 13:36
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch 4 times, most recently from e66ab1c to a8bc1f1 Compare September 6, 2023 18:22
jmank88
jmank88 previously approved these changes Sep 6, 2023
View reviewed changes
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch from a8bc1f1 to 1a6a28e Compare September 7, 2023 13:05
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6110132337

jmank88
jmank88 previously approved these changes Sep 7, 2023
View reviewed changes
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch from 1a6a28e to a0e84b1 Compare September 7, 2023 13:17
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6110278749

@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch 2 times, most recently from 36f928b to 738764d Compare September 7, 2023 13:18
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6110289269

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6110294471

@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch from 738764d to c4dd5d7 Compare September 11, 2023 12:41
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6146525060

@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch from c4dd5d7 to ec0e53f Compare September 11, 2023 14:26
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6147785440

jmank88
jmank88 previously approved these changes Sep 11, 2023
View reviewed changes
@chudilka1 chudilka1 force-pushed the bug/BCF-2506-evmChainId-for-id branch from ec0e53f to 04a8869 Compare September 11, 2023 14:34
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6147890757

@jmank88 jmank88 added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@chudilka1 chudilka1 requested a review from jmank88 September 14, 2023 12:09
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jmank88 jmank88 enabled auto-merge September 14, 2023 12:36
@jmank88 jmank88 added this pull request to the merge queue Sep 14, 2023
Merged via the queue into develop with commit 77dfb66 Sep 14, 2023
@jmank88 jmank88 deleted the bug/BCF-2506-evmChainId-for-id branch September 14, 2023 13:12
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chudilka1 @jmank88