BCF-2497: Refactoring sessions orm query pattern to avoid a confusing rollback tx error log #10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
patrickhuie19
force-pushed
the
fix/BCF-2497-session-error-log
branch
2 times, most recently
from
1672250 to
d915889
Compare
patrickhuie19
commented
Aug 29, 2023
patrickhuie19
force-pushed
the
fix/BCF-2497-session-error-log
branch
from
d915889 to
00d005d
Compare
patrickhuie19
commented
Sep 5, 2023
| func (o *orm) updateSessionLastUsed(sessionID string) error { | ||
| return o.q.ExecQ("UPDATE sessions SET last_used = now() WHERE id = $1", sessionID) | ||
| } | ||
|
|
||
| // ErrUserSessionExpired defines the error triggered when the user session has expired |
There was a problem hiding this comment.
If I do another revision, I'll remove this comment - it should be clear from the Error message what it is used for.
jmank88
reviewed
Sep 5, 2023
Comment on lines
+62
to
+64
| {"expired", "correctID", cltest.MustParseDuration(t, "0m"), sessions.ErrUserSessionExpired.Error(), ""}, | ||
| {"incorrect", "wrong", cltest.MustParseDuration(t, "3m"), sessions.ErrUserSessionExpired.Error(), ""}, | ||
| {"empty", "", cltest.MustParseDuration(t, "3m"), sessions.ErrEmptySessionID.Error(), ""}, |
There was a problem hiding this comment.
nit/ could switch wantError to type error, and then do a require.ErrorIs or whatever instead of string comparison.
jmank88
approved these changes
Sep 5, 2023
|
SonarQube Quality Gate
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
… rollback tx error log (#10378) * fix/BCF-2497-session-error-log: refactoring sessions orm to avoid a confusing rollback tx error log * fix/BCF-2497: updating changelog * fix/BCF-2497: refactoring out redundant query implementations * fix/BCF-2497: decomposition and redundancy refactoring
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
… rollback tx error log (#10378) * fix/BCF-2497-session-error-log: refactoring sessions orm to avoid a confusing rollback tx error log * fix/BCF-2497: updating changelog * fix/BCF-2497: refactoring out redundant query implementations * fix/BCF-2497: decomposition and redundancy refactoring
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.