(feat): Update Functions core/scripts oracle.toml template #10409
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
| @@ -31,6 +31,8 @@ func (g *generateJobSpecs) Run(args []string) { | |||
| donID := fs.String("donid", "", "don id string") | |||
| routerAddress := fs.String("contract", "", "router contract address") | |||
| truncateHostname := fs.Bool("truncateboothostname", false, "truncate host name to first segment (needed for staging DONs)") | |||
| gatewayID := fs.String("gatewayid", "", "gateway id string") | |||
| gatewayURL := fs.String("gatewayurl", "", "gateway url string") | |||
| err := fs.Parse(args) | |||
| if err != nil || nodesFile == nil || *nodesFile == "" || routerAddress == nil || *routerAddress == "" { | |||
There was a problem hiding this comment.
Is it actually a required field?
I was going off of since we aren't checking things like donID.. but looks like that might just be out of date and we should require that.
There was a problem hiding this comment.
Yeah I think everything that is in latest oracle.toml should be required.
| @@ -31,6 +31,8 @@ func (g *generateJobSpecs) Run(args []string) { | |||
| donID := fs.String("donid", "", "don id string") | |||
| routerAddress := fs.String("contract", "", "router contract address") | |||
| truncateHostname := fs.Bool("truncateboothostname", false, "truncate host name to first segment (needed for staging DONs)") | |||
| gatewayID := fs.String("gatewayid", "", "gateway id string") | |||
| gatewayURL := fs.String("gatewayurl", "", "gateway url string") | |||
There was a problem hiding this comment.
soon we will be moving to a config file... due to lots of variables.
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.