Gas prices Data Source Changes #10489

augustbleeds · 2023-09-05T14:23:48Z

This PR does the following:

Updates plugin config to accept optional gas price data source string
Instantiate a new median factory (both loopp and legacy plugins) with gas price data source
Updates ORM method to save a median plugin pipeline

Related PRs:

PR Merge Order (from top to bottom in order)
1. libocr
  - NumericalMedianFactory gets changed to have a gas price data source
  - Note: (If someone bumps libocr in core, median factory will need to be updated with nil)
  - Note: (You will not be able to bump libocr in chainlink-relay until the below PR gets merged)
2. chainlink-relay
  - Currently uses the replace directive, once libocr is merged we remove replace directive and bump the version of libocr
  - The plugin median interface is updated to include gas price data source
  - Begins the grpc service for gas price data source
  - Note: (You cannot bump chainlink-relay in chainlink repo until the PR below bets merged)
3. chainlink-feeds
4. chainlink
  - Uses replace directive for both chainlink-relay and libocr. They should get updated when the respective repos get updated
  - Parses TOML config for (optional) gas price data source and passes it into median factory.

github-actions · 2023-09-05T14:24:10Z

I see that you haven't updated any README files. Would it make sense to do so?

augustbleeds · 2023-09-05T16:10:07Z

retest

github-actions · 2023-09-07T15:37:51Z

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6111856435

github-actions · 2023-09-07T15:56:13Z

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6112031805

github-actions · 2023-09-07T15:57:26Z

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6112032320

github-actions · 2023-09-07T20:54:14Z

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114674548

github-actions · 2023-09-08T13:44:30Z

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6122503216

github-actions · 2023-09-08T21:03:14Z

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126405294

augustbleeds · 2023-09-08T21:13:05Z

.tool-versions

@@ -1,7 +1,7 @@
 golang 1.20.4
 mockery 2.28.1
 nodejs 16.16.0
-postgres 13.3
+postgres 15.1


will remove before PR is ready to be merged... I do this because I test against postgres 15 locally

augustbleeds · 2023-09-08T21:13:58Z

core/services/job/orm.go

@@ -282,16 +282,27 @@ func (o *orm) CreateJob(jb *Job, qopts ...pg.QOpt) error {

 			if jb.OCR2OracleSpec.PluginType == types.Median {
 				var cfg medianconfig.PluginConfig
+				validatePipeline := func(s string) error {


simplify plugin pipeline validation logic

augustbleeds · 2023-09-08T21:14:52Z

core/services/ocr2/plugins/median/config/config.go

 }

 // ValidatePluginConfig validates the arguments for the Median plugin.
-func ValidatePluginConfig(config PluginConfig) error {
+func (config *PluginConfig) ValidatePluginConfig() error {


made these methods instead of functions

augustbleeds · 2023-09-08T21:15:34Z

core/services/ocr2/plugins/median/services.go

@@ -121,11 +131,11 @@ func NewMedianServices(ctx context.Context,
 			abort()
 			return
 		}
-		median := loop.NewMedianService(lggr, telem, cmdFn, medianProvider, dataSource, juelsPerFeeCoinSource, errorLog)
+		median := loop.NewMedianService(lggr, telem, cmdFn, medianProvider, dataSource, juelsPerFeeCoinSource, gasPriceDataSource, errorLog)


data source should work with both loopp and legacy plugins.

cl-sonarqube-production · 2023-09-08T21:25:41Z

SonarQube Quality Gate

Maintainability Rating on New Code (is worse than A)
8.21% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint in your IDE.

jmank88 · 2023-09-18T11:44:56Z

core/services/ocr2/plugins/median/services.go

@@ -106,11 +107,20 @@ func NewMedianServices(ctx context.Context,
 		runResults,
 		chEnhancedTelem,
 	), ocrcommon.NewInMemoryDataSource(pipelineRunner, jb, pipeline.Spec{
-		ID:           jb.ID,
+		ID:           jb.ID, // why do we choose the same job id for getting juelsperfee number as the data source?


Is this an issue we need to fix? or document in a ticket?

This was just a question i had. I think I found the answer: they're part of the same job. ( will delete comment)

github-actions · 2023-11-18T00:12:10Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

cl-sonarqube-production · 2024-01-22T16:31:00Z

SonarQube Quality Gate

Maintainability Rating on New Code (is worse than A)
0.0% Coverage on New Code (is less than 75%)
8.68% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint in your IDE.

RensR · 2024-01-22T16:48:53Z

I assume the Foundry dependency change is not intentional? If not, please undo it.

augustbleeds · 2024-02-08T17:46:57Z

I assume the Foundry dependency change is not intentional? If not, please undo it.

yeah, it was an artifact of testing unrelated changes. I'll remove it

github-actions · 2024-04-09T00:12:57Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

augustbleeds requested review from a team, jmank88, krehermann and connorwstein as code owners September 5, 2023 14:23

augustbleeds marked this pull request as draft September 5, 2023 14:24

augustbleeds mentioned this pull request Sep 5, 2023

Change PluginMedian Interface smartcontractkit/chainlink-common#166

Closed

augustbleeds marked this pull request as ready for review September 5, 2023 16:12

augustbleeds added 3 commits September 5, 2023 12:42

main change

c3a8e5a

update chainlink-relay to custom branch

79d1a7c

trigger

640a094

augustbleeds force-pushed the augustus.gas-prices-median-reporting branch from 3fba394 to 640a094 Compare September 5, 2023 16:47

augustbleeds closed this Sep 5, 2023

augustbleeds reopened this Sep 5, 2023

augustbleeds and others added 5 commits September 5, 2023 12:55

update deps

d027c00

updating replace

5b7051a

Merge branch 'develop' into augustus.gas-prices-median-reporting

9b16997

update go.sum

6fea13e

update chainlink-relay

df3b7cb

go mod tidy

402215f

modify tests + lint

5676732

augustbleeds requested review from jkongie and samsondav as code owners September 7, 2023 20:04

merge develop

04b414f

typo with config

f2e4ccc

augustbleeds added 3 commits September 8, 2023 16:48

update chainlink-relay

6b49c34

add gaspricedatasource to loopp plugin

251f566

merge develop

1437137

augustbleeds changed the title ~~DRAFT: Gas prices change~~ Gas prices Data Source Changes Sep 8, 2023

augustbleeds commented Sep 8, 2023

View reviewed changes

jmank88 requested review from cedric-cordenier and george-dorin September 8, 2023 21:20

jmank88 reviewed Sep 18, 2023

View reviewed changes

calvwang9 mentioned this pull request Sep 19, 2023

BCI-1962: Add gas price to OCR reports in contracts smartcontractkit/chainlink-cosmos#374

Open

github-actions bot added the Stale label Nov 18, 2023

github-actions bot closed this Nov 26, 2023

augustbleeds reopened this Jan 10, 2024

github-actions bot removed the Stale label Jan 11, 2024

git merge and update modules

67040ac

augustbleeds requested a review from RensR as a code owner January 22, 2024 16:25

augustbleeds had a problem deploying to sdlc January 22, 2024 16:26 — with GitHub Actions Failure

github-actions bot added the Stale label Apr 9, 2024

github-actions bot closed this Apr 17, 2024

augustbleeds deleted the augustus.gas-prices-median-reporting branch May 23, 2024 23:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gas prices Data Source Changes #10489

Gas prices Data Source Changes #10489

augustbleeds commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023

augustbleeds commented Sep 5, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 8, 2023

github-actions bot commented Sep 8, 2023

augustbleeds Sep 8, 2023

augustbleeds Sep 8, 2023

augustbleeds Sep 8, 2023

augustbleeds Sep 8, 2023 •

edited

Loading

cl-sonarqube-production bot commented Sep 8, 2023

jmank88 Sep 18, 2023

augustbleeds Jan 22, 2024

github-actions bot commented Nov 18, 2023

cl-sonarqube-production bot commented Jan 22, 2024

RensR commented Jan 22, 2024

augustbleeds commented Feb 8, 2024

github-actions bot commented Apr 9, 2024

Gas prices Data Source Changes #10489

Gas prices Data Source Changes #10489

Conversation

augustbleeds commented Sep 5, 2023 • edited Loading

github-actions bot commented Sep 5, 2023

augustbleeds commented Sep 5, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 8, 2023

github-actions bot commented Sep 8, 2023

augustbleeds Sep 8, 2023

Choose a reason for hiding this comment

augustbleeds Sep 8, 2023

Choose a reason for hiding this comment

augustbleeds Sep 8, 2023

Choose a reason for hiding this comment

augustbleeds Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Sep 8, 2023

jmank88 Sep 18, 2023

Choose a reason for hiding this comment

augustbleeds Jan 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2023

cl-sonarqube-production bot commented Jan 22, 2024

RensR commented Jan 22, 2024

augustbleeds commented Feb 8, 2024

github-actions bot commented Apr 9, 2024

augustbleeds commented Sep 5, 2023 •

edited

Loading

augustbleeds Sep 8, 2023 •

edited

Loading