Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCF-2492 Remove evm default chain id #10490

Merged
merged 56 commits into from
Sep 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
2de282d
Remove evm default chain id usage
ilija42 Sep 5, 2023
63d8a6f
Remove the rest of evm default chain id usage
ilija42 Sep 5, 2023
99096ab
Enforce evmChainID to be defined in all jobspecs where present
ilija42 Sep 5, 2023
48ca938
Remove setdefault chain id from NewLegacyChainsWithChain() mock
ilija42 Sep 5, 2023
6e1d5a0
Change cltest NewApplicationWithConfig to init evmopts if evm enabled
ilija42 Sep 6, 2023
6fbea6b
Fix pipeline & eth_keys & jobs controller tests to encode evmChainID
ilija42 Sep 6, 2023
58df0cf
Add evmChainID to test tomls and to VRFSpecParams testspec struct
ilija42 Sep 6, 2023
587c0d8
Add evmChainID to vrf submit_tx pipeline vars and testspec source
ilija42 Sep 6, 2023
fbcd0b6
Add evmChainID to testspecs job specs where missing
ilija42 Sep 6, 2023
ecca443
Add evmChainID flags to shell local tests
ilija42 Sep 6, 2023
6d04fc6
Change TestORM_CreateJob_OCR_DuplicatedContractAddress
ilija42 Sep 6, 2023
f8c55ea
Change orm validation missing evmChainID error message
ilija42 Sep 6, 2023
37790d8
Change tests that relied on default chainID to use replacement func
ilija42 Sep 6, 2023
1b79c95
Add deprecated tag to default chainID helper funcs and update err msg
ilija42 Sep 6, 2023
5881147
comment out test case in TestShell_ReplayBlock
ilija42 Sep 6, 2023
082174a
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 6, 2023
b4236d3
minor tests fix
ilija42 Sep 6, 2023
b887874
Add evmchainID to spec to keepers and flux integration tests
ilija42 Sep 6, 2023
8868ada
Add evmChainID to vrfv2 pipeline vars
ilija42 Sep 7, 2023
fff8fc6
Fix evmChainID parsing in estimategas pipeline task
ilija42 Sep 7, 2023
598b341
Add evmChainID to estimate gas and eth call pipeline tasks vars spec
ilija42 Sep 7, 2023
4e3f8b4
Fix/Change cmds tests to use evmChainID
ilija42 Sep 7, 2023
096706b
Fix vrf integration tests and helpers to use evmChainID
ilija42 Sep 7, 2023
e133425
Add evmChainID parsing string as default val to pipeline tasks that u…
ilija42 Sep 8, 2023
93b392c
Add evmChainID to specs in internal features_test
ilija42 Sep 8, 2023
0c9c3e3
Add evmChainID to vrf and ocr smoke test job specs
ilija42 Sep 8, 2023
89d112e
Fix evmChainID in keepers tests
ilija42 Sep 8, 2023
29f84d7
Fix evmChainID in fluxmonitorv2 tests
ilija42 Sep 8, 2023
353557f
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 11, 2023
c728bda
Fix estimategas, ethcall/tx default evmChainID values for parsing vars
ilija42 Sep 11, 2023
dfc4c5c
Remove default tag from EstimateGasLimitTask.EVMChainID
ilija42 Sep 11, 2023
2b38531
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 11, 2023
0ade421
Add evmChainID to pipeline vars in directRequest handleOracleRequest
ilija42 Sep 11, 2023
f93ec01
Add evmChainID to all pipeline vars where needed
ilija42 Sep 11, 2023
87bf52d
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 11, 2023
b8fb5ec
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 11, 2023
fe42327
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 12, 2023
2a6624b
Resolve develop merge issues
ilija42 Sep 12, 2023
568632b
Fix evmChainID pipeline vars parsing
ilija42 Sep 12, 2023
e8ca0f5
Add mock calls to direct request tests for EVMChainID() call
ilija42 Sep 12, 2023
3a2b560
Run make go generate
ilija42 Sep 12, 2023
792ffac
Add unit tests for job creation evmChainID validation
ilija42 Sep 12, 2023
d3d05da
Fix keepers and flux smoke tests to have evmChainID in the jobspec
ilija42 Sep 12, 2023
9f8e1b7
Fix smoke test job spec evmChainID for ocr, reorg, runlog and vrf
ilija42 Sep 12, 2023
91b1e29
Fix integration tests by adding chainID to OCR task and Bootstrap Spec
ilija42 Sep 12, 2023
3a18f6a
Fix integrations test OCRTaskJobSpec struct field naming case
ilija42 Sep 12, 2023
490d153
minor fix to keeper job creation smoke test
ilija42 Sep 13, 2023
51e66de
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 13, 2023
aafc41c
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 13, 2023
ef7d1a3
Remove unnecessary error wrap in ValidatedOracleSpecToml
ilija42 Sep 13, 2023
220050f
Remove shell_remote test case that relied on default evmChainID
ilija42 Sep 13, 2023
4982867
Remove keystore migrate as all v1 keys should have been migrated by now
ilija42 Sep 14, 2023
24556cb
Use %q in (c *LegacyChains) Get() for better error msg output
ilija42 Sep 14, 2023
575b15b
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
ilija42 Sep 14, 2023
164bb39
Fix TestShell_ReplayBlocks test by fixing err message assert
ilija42 Sep 14, 2023
ba4ac9e
Add changes to CHANGELOG.md
ilija42 Sep 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add changes to CHANGELOG.md
  • Loading branch information
ilija42 committed Sep 14, 2023
commit ba4ac9e47ebf2d346f990ec7c625d73f425335c2
2 changes: 2 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed

- Removed support for sending telemetry to the deprecated Explorer service. All nodes will have to remove `Explorer` related keys from TOML configuration and env vars.
- Removed default evmChainID logic where evmChainID was implicitly injected into the jobspecs based on node EVM chainID toml configuration. All newly created jobs(that have evmChainID field) will have to explicitly define evmChainID in the jobspec.
- Removed keyset migration that migrated v1 keys to v2 keys. All keys should've been migrated by now, and we don't permit creation of new v1 keys anymore

All nodes will have to remove the following secret configurations:
* `Explorer.AccessKey`
Expand Down