Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-562 Improved load test client contract #10504

Merged
merged 8 commits into from
Sep 6, 2023

Conversation

KuphJr
Copy link
Contributor

@KuphJr KuphJr commented Sep 5, 2023

  • Added method to send requests that use DON hosted secrets
  • Added method to send request that has been encoded off-chain (this may not be necessary, but could be used if desired)
  • Increased callback gas limit
    • This should avoid any errors when storing larger responses or error messages
  • Save responses or errors as bytes instead of bytes32
    • This should solve the problem of responses or error messages being curtailed, hopefully assisting with debugging
    • Not sure if this will break the test scripts? Cc: @skudasov
  • Fixed contract method param comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

skudasov
skudasov previously approved these changes Sep 5, 2023
@skudasov skudasov requested a review from a team as a code owner September 5, 2023 20:24
@skudasov
Copy link
Collaborator

skudasov commented Sep 5, 2023

  • Added method to send requests that use DON hosted secrets

  • Added method to send request that has been encoded off-chain (this may not be necessary, but could be used if desired)

  • Increased callback gas limit

    • This should avoid any errors when storing larger responses or error messages
  • Save responses or errors as bytes instead of bytes32

    • This should solve the problem of responses or error messages being curtailed, hopefully assisting with debugging
    • Not sure if this will break the test scripts? Cc: @skudasov
  • Fixed contract method param comments

Fixed the tests, let's merge like that, I can add more cases later, thanks!

@KuphJr KuphJr enabled auto-merge September 5, 2023 21:05
@KuphJr KuphJr added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@skudasov skudasov added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@skudasov skudasov added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@skudasov skudasov changed the title Improved load test client contract TT-562 Improved load test client contract Sep 6, 2023
@KuphJr KuphJr added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@KuphJr KuphJr added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@KuphJr KuphJr enabled auto-merge September 6, 2023 18:20
@KuphJr KuphJr added this pull request to the merge queue Sep 6, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Merged via the queue into develop with commit a0e97cf Sep 6, 2023
@KuphJr KuphJr deleted the chore/improve-load-test-client branch September 6, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants