Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/gh-actions-setup-postgres: fixing buggy Setup Postgres step #10512

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Sep 6, 2023

docker compose ps is sometimes returning an array and sometimes an object. This change makes the script resilient to either state.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@patrickhuie19 patrickhuie19 force-pushed the fix/gh-actions-setup-postgres branch from e5f9213 to 7498c90 Compare September 6, 2023 03:45
@patrickhuie19 patrickhuie19 force-pushed the fix/gh-actions-setup-postgres branch from 82ae60f to 17aa4d0 Compare September 6, 2023 04:19
@patrickhuie19 patrickhuie19 marked this pull request as ready for review September 6, 2023 04:31
@patrickhuie19 patrickhuie19 changed the title fix/gh-actions-setup-postgres: adding more logging to Setup Postgres step fix/gh-actions-setup-postgres: fixing buggy Setup Postgres step Sep 6, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmank88 jmank88 added this pull request to the merge queue Sep 6, 2023
Merged via the queue into develop with commit c40169c Sep 6, 2023
95 checks passed
@jmank88 jmank88 deleted the fix/gh-actions-setup-postgres branch September 6, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants