-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EvmFeeEstimator return Optimistic Rollup's L1BaseFee #10557
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
af3e893
Draft impl
matYang 33af306
update configs
matYang e5f5aff
move l1 knowledge from EVMEstimator to WrappedEVMFeeEstimator
matYang d6e8274
nit fixes
matYang d5ab581
change L1BaseFee to L1GasPrice
matYang 56efe1d
update mock
matYang 41f5bd4
use chain type instead of modifying chain config
matYang 055aeb1
add mocks
matYang 20272a4
beef up models tests
matYang e5d1295
beef up l1 oracle tests
matYang 008a455
small nits
matYang 19282f2
address comments
matYang 7074410
Merge branch 'develop' into evm-estimator-return-gas-price
matYang 06b61ba
fix chaintype panic
matYang 42c5a00
address comments
matYang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of code can happen before even calling l1Oracle.Ready()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd only execute either when
e.l1Oracle
is nil, ore.l1Oracle.Ready()
has been called. The drawback is ifEvmEstimator
andl1Oracle
both error, onlyerrEVM
will be surfaced. I think that's fine since it doesn't alter the outcome andEvmEstimator
is the more critical component.