golangci-lint #10577
Merged
golangci-lint #10577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
force-pushed
the
golangci-lint-2023-09-10
branch
8 times, most recently
from
f1975f5 to
6118c37
Compare
jmank88
commented
Sep 16, 2023
| @@ -25,7 +25,7 @@ import ( | |||
| ) | |||
|
|
|||
| type Runner interface { | |||
| ExecuteRun(ctx context.Context, spec pipeline.Spec, vars pipeline.Vars, l logger.Logger) (run pipeline.Run, trrs pipeline.TaskRunResults, err error) | |||
| ExecuteRun(ctx context.Context, spec pipeline.Spec, vars pipeline.Vars, l logger.Logger) (run *pipeline.Run, trrs pipeline.TaskRunResults, err error) | |||
There was a problem hiding this comment.
We were copying around these values even though we end up needing a pointer for later uses anyways. Using a pointer also fixes the linter warnings indirectly.
jmank88
commented
Sep 16, 2023
Comment on lines
-36
to
-43
| randomnessFulfillmentRequestedEvent string = "RandomnessFulfillmentRequested" | ||
| randomWordsFulfilledEvent string = "RandomWordsFulfilled" | ||
| newTransmissionEvent string = "NewTransmission" | ||
| outputsServedEvent string = "OutputsServed" |
jmank88
force-pushed
the
golangci-lint-2023-09-10
branch
from
6118c37 to
fd27dff
Compare
jmank88
requested review from
jkongie,
samsondav,
a team,
sdrug,
martin-cll,
connorwstein,
prashantkumar1982,
krehermann and
PiotrTrzpil
as code owners
jmank88
force-pushed
the
golangci-lint-2023-09-10
branch
from
fd27dff to
9b5a6d0
Compare
jmank88
force-pushed
the
golangci-lint-2023-09-10
branch
from
9b5a6d0 to
37bf713
Compare
jmank88
force-pushed
the
golangci-lint-2023-09-10
branch
from
37bf713 to
d5d85c0
Compare
receiver-naming: receiver name X should be consistent with previous receiver name Y for T `X` is a misspelling of `Y` (misspell)
jmank88
force-pushed
the
golangci-lint-2023-09-10
branch
from
d5d85c0 to
ca72c10
Compare
|
SonarQube Quality Gate
|
krehermann
reviewed
Sep 22, 2023
krehermann
approved these changes
Sep 22, 2023
krehermann
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G601: Implicit memory aliasing in for loop.
receiver-naming: receiver name X should be consistent with previous receiver name Y for T
Xis a misspelling ofY(misspell)