Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluxmonitor to use IdempotencyKey when creating Tx #10589

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Update fluxmonitor to use IdempotencyKey when creating Tx #10589

merged 3 commits into from
Sep 19, 2023

Conversation

amit-momin
Copy link
Contributor

  • Removed use of a Queryer when submitting Tx to TXM
  • Updated logic to use an IdempotencyKey to prevent double send. Using fluxmonitor- + run ID

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6151194702

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6151233996

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6151799968

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6161385127

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6162813482

@amit-momin amit-momin force-pushed the txm/BCI-1892 branch 2 times, most recently from e9864cb to 81a8004 Compare September 13, 2023 22:15
@amit-momin amit-momin marked this pull request as ready for review September 13, 2023 22:31
@samsondav samsondav added this pull request to the merge queue Sep 19, 2023
samsondav
samsondav requested changes Sep 19, 2023
View reviewed changes
core/services/fluxmonitorv2/orm_test.go Outdated
@@ -185,8 +185,9 @@ func TestORM_CreateEthTransaction(t *testing.T) {
payload = []byte{1, 0, 0}
gasLimit = uint32(21000)
)

idempotencyKey := "fluxmonitor-1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might conflict with the other test resulting in locking delays. Can we randomly generate it please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. I've updated these tests to use uuid instead now.

@samsondav samsondav removed this pull request from the merge queue due to a manual request Sep 19, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@samsondav samsondav added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit c32eb83 Sep 19, 2023
99 checks passed
@samsondav samsondav deleted the txm/BCI-1892 branch September 19, 2023 23:11
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

@jkongie jkongie Awaiting requested review from jkongie

@PiotrTrzpil PiotrTrzpil Awaiting requested review from PiotrTrzpil

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit-momin @samsondav @prashantkumar1982