Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-526] Allow Parallel Tests To Work #10591

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

tateexon
Copy link
Contributor

@tateexon tateexon commented Sep 11, 2023

Use unique base config for each env, we were overwriting the BaseConfig in parallel tests.
Reduce the github runners used in keeper/automation suites by running all the sub test loops in parallel, this could be improved further but may make things harder to triage.
Add ability for the test json lists to specify github runner labels and the parallel test count to use for that test.

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

Use unique base config for each env
@tateexon tateexon force-pushed the TT-526-Parallel-E2E-Testing branch from 5aca7a0 to e413ab4 Compare September 11, 2023 22:33
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@tateexon tateexon force-pushed the TT-526-Parallel-E2E-Testing branch from 6ffb5bf to 49876df Compare September 11, 2023 23:05
@github-actions
Copy link
Contributor

@tateexon tateexon force-pushed the TT-526-Parallel-E2E-Testing branch from 49876df to 5baf181 Compare September 12, 2023 14:09
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@tateexon tateexon marked this pull request as ready for review September 12, 2023 14:52
@tateexon tateexon requested review from a team as code owners September 12, 2023 14:52
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@tateexon tateexon enabled auto-merge September 12, 2023 15:14
@tateexon tateexon added this pull request to the merge queue Sep 12, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@anirudhwarrier anirudhwarrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at test logs, something seems wrong. For tests with sub-tests, logs are missing. Eg: https://github.com/smartcontractkit/chainlink/actions/runs/6161174369/job/16719949861?pr=10591#step:5:1496

Merged via the queue into develop with commit e161477 Sep 12, 2023
103 checks passed
@tateexon tateexon deleted the TT-526-Parallel-E2E-Testing branch September 12, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants