Bumping chainlink-relay to the version that contains CCIP plugin types #10597
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6157808812 |
mateusz-sekara
force-pushed
the
relayer-bump
branch
from
b20801f to
ac95406
Compare
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6159410712 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6159485795 |
|
It looks like some breaking changes for mercury are blocking here. I thought this PR might fix it, but it has the same problem: |
mateusz-sekara
dismissed stale reviews from RensR and cedric-cordenier
via
436fd11
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6160161619 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6160188620 |
@jmank88 I think I know how to fix these, I will give it a try |
| @@ -67,7 +67,7 @@ var ( | |||
| } | |||
| rawReportingPluginConfig = relaymercury.OffchainConfig{ | |||
| ExpirationWindow: 1, | |||
| BaseUSDFeeCents: 100, | |||
| BaseUSDFee: decimal.NewFromInt(100), | |||
There was a problem hiding this comment.
Is this right? IIUC @samsondav may have just changed the scale of these units
There was a problem hiding this comment.
Or probably irrelevant since this is only a test. Surprised it didn't affect production code though 🤔
There was a problem hiding this comment.
All tests are green now ;)
|
SonarQube Quality Gate
|
mateusz-sekara
requested review from
cedric-cordenier,
jmank88,
RensR and
samsondav
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Chainlink Relayer changes smartcontractkit/chainlink-common#172