Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify with single payment token #10603

Merged
merged 31 commits into from
Sep 19, 2023
Merged

Verify with single payment token #10603

merged 31 commits into from
Sep 19, 2023

Conversation

austinborn
Copy link
Collaborator

@austinborn austinborn commented Sep 12, 2023 •
edited
Loading

Instead of appending the ERC-20 token to each report payload, simply add a separate parameter of type bytes for the user to specify a single fee token for the entire request.

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6161696860

@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@austinborn austinborn force-pushed the verify-single-payment-token branch from a6cf76c to e2df7e1 Compare September 13, 2023 18:26
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@austinborn austinborn marked this pull request as ready for review September 13, 2023 22:08
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

2 similar comments
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Fletch153
Fletch153 previously approved these changes Sep 13, 2023
View reviewed changes
@austinborn austinborn requested a review from a team as a code owner September 14, 2023 07:29
@austinborn austinborn force-pushed the verify-single-payment-token branch from 72f9674 to 8f57dcd Compare September 14, 2023 07:40
Fletch153
Fletch153 previously approved these changes Sep 14, 2023
View reviewed changes
Fletch153
Fletch153 previously approved these changes Sep 18, 2023
View reviewed changes
contracts/src/v0.8/llo-feeds/VerifierProxy.sol Outdated Show resolved Hide resolved
@austinborn austinborn disabled auto-merge September 19, 2023 17:42
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@austinborn austinborn force-pushed the verify-single-payment-token branch from c415d30 to 280acd0 Compare September 19, 2023 18:34
Fletch153
Fletch153 previously approved these changes Sep 19, 2023
View reviewed changes
@austinborn austinborn force-pushed the verify-single-payment-token branch from c1e139a to 7bed387 Compare September 19, 2023 18:59
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@austinborn austinborn added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit af1f6e7 Sep 19, 2023
101 of 103 checks passed
@austinborn austinborn deleted the verify-single-payment-token branch September 19, 2023 20:31
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fletch153 Fletch153 Fletch153 approved these changes

@se3000 se3000 Awaiting requested review from se3000

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinborn @Fletch153