Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bcf 2492 remove default evm chain id test #10618

Closed
wants to merge 48 commits into from
Closed

Bcf 2492 remove default evm chain id test #10618

wants to merge 48 commits into from

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 13, 2023

No description provided.

ilija42 added 30 commits September 5, 2023 16:45
@ilija42
Remove evm default chain id usage
2de282d 
 - Remove default chain id from LegacyChainContainer
 - Add alternate function for default chainID in tests
@ilija42
Remove the rest of evm default chain id usage
63d8a6f 
 - Remove default chain id from LoopRelayAdapter
 - Remove default chain id use from common.go getChain
 - Remove default chain id use from evm relayer init
@ilija42
Enforce evmChainID to be defined in all jobspecs where present
99096ab
@ilija42
Remove setdefault chain id from NewLegacyChainsWithChain() mock
48ca938
@ilija42
Change cltest NewApplicationWithConfig to init evmopts if evm enabled
6e1d5a0
@ilija42
Fix pipeline & eth_keys & jobs controller tests to encode evmChainID
6fbea6b
@ilija42
Add evmChainID to test tomls and to VRFSpecParams testspec struct
58df0cf
@ilija42
Add evmChainID to vrf submit_tx pipeline vars and testspec source
587c0d8
@ilija42
Add evmChainID to testspecs job specs where missing
fbcd0b6
@ilija42
Add evmChainID flags to shell local tests
ecca443
@ilija42
Change TestORM_CreateJob_OCR_DuplicatedContractAddress
6d04fc6 
- Remove code that relied on default chainID
@ilija42
Change orm validation missing evmChainID error message
f8c55ea
@ilija42
Change tests that relied on default chainID to use replacement func
37790d8 
- Fix evm transfer controller tests
- Fix integration test helpers
- Fix head tracker tests
- Fix evm transaction commands test
@ilija42
Add deprecated tag to default chainID helper funcs and update err msg
1b79c95
@ilija42
comment out test case in TestShell_ReplayBlock
5881147
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
082174a 
…fault-evm-chainID

# Conflicts:
#	core/internal/cltest/mocks.go
#	core/services/chainlink/relayer_chain_interoperators.go
#	core/services/relay/evm/mocks/loop_relay_adapter.go
#	core/services/relay/evm/relayer_extender.go
@ilija42
minor tests fix
b4236d3
@ilija42
Add evmchainID to spec to keepers and flux integration tests
b887874
@ilija42
Add evmChainID to vrfv2 pipeline vars
8868ada
@ilija42
Fix evmChainID parsing in estimategas pipeline task
fff8fc6
@ilija42
Add evmChainID to estimate gas and eth call pipeline tasks vars spec
598b341
@ilija42
Fix/Change cmds tests to use evmChainID
4e3f8b4
@ilija42
Fix vrf integration tests and helpers to use evmChainID
096706b
@ilija42
Add evmChainID parsing string as default val to pipeline tasks that u…
e133425 
…se it
@ilija42
Add evmChainID to specs in internal features_test
93b392c
@ilija42
Add evmChainID to vrf and ocr smoke test job specs
0c9c3e3
@ilija42
Fix evmChainID in keepers tests
89d112e
@ilija42
Fix evmChainID in fluxmonitorv2 tests
29f84d7
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
353557f 
…fault-evm-chainID
@ilija42
Fix estimategas, ethcall/tx default evmChainID values for parsing vars
c728bda
@ilija42
Remove default tag from EstimateGasLimitTask.EVMChainID
dfc4c5c
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
2b38531 
…fault-evm-chainID
@ilija42
Add evmChainID to pipeline vars in directRequest handleOracleRequest
0ade421
@ilija42
Add evmChainID to all pipeline vars where needed
f93ec01
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
87bf52d 
…fault-evm-chainID

# Conflicts:
#	core/services/chainlink/relayer_chain_interoperators.go
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
b8fb5ec 
…fault-evm-chainID

# Conflicts:
#	core/services/relay/evm/relayer_extender.go
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-2492-remove-de…
fe42327 
…fault-evm-chainID
@ilija42
Resolve develop merge issues
2a6624b
@ilija42
Fix evmChainID pipeline vars parsing
568632b
@ilija42
Add mock calls to direct request tests for EVMChainID() call
e8ca0f5
@ilija42
Run make go generate
3a2b560
@ilija42
Add unit tests for job creation evmChainID validation
792ffac
@ilija42
Fix keepers and flux smoke tests to have evmChainID in the jobspec
d3d05da
@ilija42
Fix smoke test job spec evmChainID for ocr, reorg, runlog and vrf
9f8e1b7
@ilija42
Fix integration tests by adding chainID to OCR task and Bootstrap Spec
91b1e29
@ilija42
Fix integrations test OCRTaskJobSpec struct field naming case
3a18f6a
@ilija42
minor fix to keeper job creation smoke test
490d153
@ilija42
add log
abb2a1e
@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.3% 91.3% Coverage
2.2% 2.2% Duplication

@ilija42 ilija42 closed this Sep 13, 2023
@ilija42 ilija42 deleted the BCF-2492-remove-default-evm-chainID-test branch September 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eutopian eutopian Awaiting requested review from eutopian eutopian will be requested when the pull request is marked ready for review eutopian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilija42