Multichain telemetry support #10623
Merged
Multichain telemetry support #10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
…ultichain-telemetry-support # Conflicts: # core/services/chainlink/application.go # core/services/telemetry/explorer.go
george-dorin
requested review from
jkongie,
jmank88,
krehermann,
connorwstein and
samsondav
as code owners
george-dorin
requested review from
skubakdj,
sirenko,
jmank88 and
cedric-cordenier
and removed request for
jkongie,
jmank88,
samsondav,
connorwstein and
krehermann
jmank88
reviewed
Sep 18, 2023
cedric-cordenier
previously approved these changes
Sep 27, 2023
jmank88
reviewed
Oct 3, 2023
jmank88
previously approved these changes
Oct 4, 2023
…port # Conflicts: # core/services/synchronization/telemetry_ingress_batch_client.go
|
SonarQube Quality Gate
|
jmank88
approved these changes
Oct 13, 2023
george-dorin
deleted the
feature/BCF-2393-multichain-telemetry-support
branch
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Initial draft * Add manager * Update config TOML * Update config tests * Add telemetry manager tests * Fix lint * Add CHANGELOG.md * Update TelemetryService Send interface * Fix bad merge * Fix hanging tests * Change config from TelemetryIngressEndpoint to TelemetryIngress.Endpoints * - Fix wrong context being passed * - Remove protocol prefix from telemetry URL - Drop context from TelemPayload * - Fix context in tests * - Update CHANGELOG.md * - Add fields back and show error * - Fix failing tests * Move changelog entry to [dev] * Update so that telemetry can still be configured the old way * Update CONFIG.md
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multi-chain telemetry support, telemetry endpoints can be defined in the config TOML.
Moving forward we want to deprecate
TelemetryIngress.URLandTelemetryIngress. ServerPubKey.GenMonitoringEndpointnow takes two extra parametersnetworkandchainIDto route telemetry to the correct endpoint: