Enables Skipping More Tests #10678
Merged
Enables Skipping More Tests #10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalverra
requested review from
a team,
chainchad,
javuto,
jkongie,
jmank88 and
samsondav
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
AnieeG
approved these changes
Sep 18, 2023
jmank88
approved these changes
Sep 18, 2023
We could also leverage the |
chainchad
approved these changes
Sep 18, 2023
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
skip-smoke-teststag is handy for draft PRs where you don't care about test results yet, so why waste time and resources running them? This is especially helpful when using a common workflow of building a new Chainlink image for use in soak tests. So far we've only used this tag to skip E2E smoke tests, but it can be expanded to skip the core unit and integration tests as well.Tests are still required to complete successfully to merge, and will still run by default.