Bump npm dependencies #10679
Merged
Bump npm dependencies #10679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
requested review from
a team,
chainchad,
javuto,
jkongie,
jmank88,
samsondav,
se3000 and
connorwstein
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
RensR
commented
Sep 18, 2023
| @@ -0,0 +1,2 @@ | |||
| auto-install-peers=true | |||
| strict-peer-dependencies=false | |||
There was a problem hiding this comment.
required due to lockfileVersion 6.0
RensR
commented
Sep 18, 2023
| @@ -54,6 +54,7 @@ let config = { | |||
| allowUnlimitedContractSize: Boolean( | |||
| process.env.ALLOW_UNLIMITED_CONTRACT_SIZE, | |||
| ), | |||
| hardfork: 'merge', | |||
There was a problem hiding this comment.
required due to upgrade to hardhat 2.17 which defaults to shanghai which causes a test to fail
RensR
commented
Sep 18, 2023
| @@ -31,10 +31,7 @@ describe('UpkeepTranscoder', () => { | |||
| const encodedData = '0xc0ffee' | |||
|
|
|||
| it('reverts if the from type is not an enum value', async () => { | |||
| await evmRevert( | |||
There was a problem hiding this comment.
@smartcontractkit/keepers this test failed after bumping Hardhat as it didn't revert with the given message. It still reverts so I removed the message component
There was a problem hiding this comment.
I'm not worried about it
RyanRHall
approved these changes
Sep 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.