Format Block Number As Hex #10680
Format Block Number As Hex #10680
Conversation
An unmarshalling error was reported on the block number being passed to an rpc client instance if the block number was a big.Int. The solution was to format it as a hex encoded uint64 value.
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
| @@ -235,7 +235,7 @@ func (r *EvmRegistry) allowedToUseMercury(opts *bind.CallOpts, upkeepId *big.Int | |||
| } | |||
|
|
|||
| // call checkCallback function at the block which OCR3 has agreed upon | |||
| err = r.client.CallContext(opts.Context, &resultBytes, "eth_call", args, opts.BlockNumber) | |||
| err = r.client.CallContext(opts.Context, &resultBytes, "eth_call", args, hexutil.EncodeUint64(opts.BlockNumber.Uint64())) | |||
There was a problem hiding this comment.
can we use hexutil.EncodeBig as is used in other places
There was a problem hiding this comment.
I think both are being used in different place of the code. Uint makes more sense to me since negative numbers aren't valid blocks anyway.
There was a problem hiding this comment.
the other parts of code are within the same check pipeline flow on EVM registry https://github.com/smartcontractkit/chainlink/blob/develop/core/services/ocr2/plugins/ocr2keeper/evm21/registry_check_pipeline.go#L212-L219 so consistency would be better (which could be either way)
Please thoroughly test this e2e before merging
There was a problem hiding this comment.
Sounds good.
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
An unmarshalling error was reported on the block number being passed to an rpc client instance if the block number was a big.Int. The solution was to format it as a hex encoded uint64 value.