Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add finality depth contraint in block subscriber #10686

Merged
merged 8 commits into from
Sep 20, 2023
Merged

add finality depth contraint in block subscriber #10686

merged 8 commits into from
Sep 20, 2023

Conversation

FelixFan1992
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@FelixFan1992 FelixFan1992 marked this pull request as ready for review September 19, 2023 14:25
@FelixFan1992 FelixFan1992 requested a review from a team as a code owner September 19, 2023 14:25
infiloop2
infiloop2 requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@infiloop2 infiloop2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes for if/else logic in verifyCheckBlock

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@infiloop2 infiloop2 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into develop with commit 3641870 Sep 20, 2023
98 checks passed
@infiloop2 infiloop2 deleted the auto-5271 branch September 20, 2023 10:38
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiloop2 infiloop2 infiloop2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixFan1992 @infiloop2