VRF-591: add ctf test for VRF V2 Plus direct funding #10721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iljapavlovs
requested review from
a team,
se3000 and
connorwstein
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
…plus-wrapper' into chore/VRF-591-add-ctf-test-vrfv2plus-wrapper
jinhoonbang
reviewed
Sep 21, 2023
contracts/src/v0.8/dev/vrf/testhelpers/VRFV2PlusWrapperLoadTestConsumer.sol
Show resolved
Hide resolved
jinhoonbang
reviewed
Sep 21, 2023
contracts/src/v0.8/dev/vrf/testhelpers/VRFV2PlusWrapperLoadTestConsumer.sol
Show resolved
Hide resolved
tateexon
reviewed
Sep 21, 2023
…plus-wrapper' into chore/VRF-591-add-ctf-test-vrfv2plus-wrapper
jinhoonbang
reviewed
Sep 21, 2023
contracts/src/v0.8/dev/vrf/testhelpers/VRFV2PlusWrapperLoadTestConsumer.sol
Outdated
Show resolved
Hide resolved
kalverra
previously approved these changes
Sep 21, 2023
kalverra
approved these changes
Sep 21, 2023
jinhoonbang
approved these changes
Sep 21, 2023
Comment on lines
+32
to
+33
| WrapperGasOverhead = uint32(50_000) | ||
| CoordinatorGasOverhead = uint32(52_000) |
There was a problem hiding this comment.
we may need to revisit these values after ongoing investigations regarding gas
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tateexon
approved these changes
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
iljapavlovs
deleted the
chore/VRF-591-add-ctf-test-vrfv2plus-wrapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.