[TT-414] Test Env E2E Builder Changes for Non EVM Chains #10753
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
tateexon
force-pushed
the
TT-414-e2e-docker-conversion
branch
2 times, most recently
from
98ebd64 to
ee647fc
Compare
tateexon
force-pushed
the
TT-414-e2e-docker-conversion
branch
from
ee647fc to
516828e
Compare
tateexon
changed the title
| te.Cfg = cfg | ||
| n := []string{te.Network.Name} | ||
| te.Geth = test_env.NewGeth(n, test_env.WithContainerName(cfg.Geth.ContainerName)) | ||
| te.MockServer = test_env.NewMockServer(n, test_env.WithContainerName(cfg.MockServer.ContainerName)) |
There was a problem hiding this comment.
@tateexon Is there an option to just pass cfg.MockServer.ContainerName as param? test_env.NewMockServer(n, cfg.MockServer.ContainerName)? This would make it simpler
There was a problem hiding this comment.
Ya we can do that. Would be a separate ticket that deals with CTF changes since these methods and patterns would need to be changed there.
| @@ -46,6 +48,32 @@ func NewCLTestEnvBuilder() *CLTestEnvBuilder { | |||
| } | |||
| } | |||
|
|
|||
| func (b *CLTestEnvBuilder) WithTestEnv(te *CLClusterTestEnv) (*CLTestEnvBuilder, error) { | |||
There was a problem hiding this comment.
@tateexon what this function does? Creates builder from config file? If yes, maybe it should not be CLTestEnvBuilder method but a normal function? And maybe a better name could be sth like "NewTestEnvBuilderFromConfig()`?
There was a problem hiding this comment.
Will add a comment to the function but I intend it to be used just like any of the other With commands except this one needs some error handling. We had handling of the CLClusterTestEnv configuration spread out and unable to easily be changed and used outside of EVM use cases so this just bundles it up into one place and exposes it as part of the builder chain.
There was a problem hiding this comment.
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.