BCF-2640: implicit evm schema #10754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
core/services/pg/locked_db.go
Outdated
| return | ||
| } | ||
|
|
||
| type ConnectionOpt func(*string) |
There was a problem hiding this comment.
This shouldn't just operate on the uri IMO, it should operate on something higher level, like a LockedDBConfig that's been turned into a struct.
| } | ||
| enc, err := json.Marshal(conn) | ||
| require.NoError(t, err) | ||
| db, err := sqlx.Open(string(dialects.TransactionWrappedPostgres), string(enc)) |
There was a problem hiding this comment.
Not sure I understand this... Why can't we just modify the connection string and add the schema to it here, rather than passing in a json blob?
krehermann
force-pushed
the
BCF-2640-implicit-schema
branch
from
c2ee8b6 to
1526b81
Compare
krehermann
force-pushed
the
BCF-2640-implicit-schema
branch
from
06b3440 to
a8332ad
Compare
krehermann
force-pushed
the
BCF-2640-implicit-schema
branch
from
a8332ad to
832e137
Compare
krehermann
changed the title
|
SonarQube Quality Gate
|
… db boundaries. hint: they are and it's painful
krehermann
force-pushed
the
BCF-2640-implicit-schema
branch
from
4d30517 to
a86f233
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.