fix: arbitrum chain id check in all ChainSpecificUtil methods #10756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arbitrum chain id check needs to be the same in all of the methods exported in the ChainSpecificUtil contract. Prior to this change getBlockNumber, getCurrentTxL1GasFees and getL1CalldataGasCost did not correctly check for all possible arbitrum chain ids. To prevent this kind of error in the future, a new private function isArbitrumChainId was created and used in all methods that need to check the chain id.
|
I see that you haven't updated any README files. Would it make sense to do so? |
kidambisrinivas
previously approved these changes
Sep 22, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kidambisrinivas
approved these changes
Sep 27, 2023
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arbitrum chain id check needs to be the same in all of the methods exported in the ChainSpecificUtil contract. Prior to this change getBlockNumber, getCurrentTxL1GasFees and getL1CalldataGasCost did not correctly check for all possible arbitrum chain ids.
To prevent this kind of error in the future, a new private function isArbitrumChainId was created and used in all methods that need to check the chain id.
Followup to #10615