Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: standardize server API and errors #10771

Merged
merged 1 commit into from
Sep 25, 2023
Merged

plugins: standardize server API and errors #10771

merged 1 commit into from
Sep 25, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Sep 24, 2023

No description provided.

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 3.4% 3.39% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

patrickhuie19
patrickhuie19 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@jmank88 jmank88 marked this pull request as ready for review September 25, 2023 11:34
@jmank88 jmank88 requested a review from krehermann as a code owner September 25, 2023 11:34
@jmank88 jmank88 added this pull request to the merge queue Sep 25, 2023
Merged via the queue into develop with commit 7a4c2bd Sep 25, 2023
80 of 82 checks passed
@jmank88 jmank88 deleted the plugins-server-errs branch September 25, 2023 15:06
@jmank88 jmank88 mentioned this pull request Sep 27, 2023
Merged
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@krehermann krehermann krehermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @krehermann @patrickhuie19