Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/service/pg: fatal exit when db connection is read-only #10847

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

core/service/pg: fatal exit when db connection is read-only #10847

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
833dbf7
core/service/pg: fatal exit when db connection is read-only
jmank88 Oct 3, 2023
4f6df96
Merge branch 'develop' into sql-read-only
nahuelbatista Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/services/pg/lease_lock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"time"

"github.com/google/uuid"
"github.com/jackc/pgconn"
"github.com/jmoiron/sqlx"
"github.com/pkg/errors"
"go.uber.org/multierr"
Expand Down Expand Up @@ -220,6 +221,11 @@ func (l *leaseLock) loop(ctx context.Context) {
}
cancel()
if err != nil {
var pgErr pgconn.PgError
const ReadOnlyTransaction = "25006"
if errors.As(err, &pgErr) && pgErr.Code == ReadOnlyTransaction {
l.logger.Fatal("Read-only connection, exiting immediately")
}
l.logger.Errorw("Error trying to refresh database lease", "err", err)
} else if !gotLease {
if err := l.db.Close(); err != nil {
Expand Down
Loading