bump libocr ;rm P2P Networking V1 & libp2p #10872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
commented
Oct 5, 2023
jmank88
force-pushed
the
rm-libp2p
branch
3 times, most recently
from
00888b9 to
badadeb
Compare
jmank88
commented
Oct 11, 2023
jmank88
commented
Oct 11, 2023
jmank88
commented
Oct 11, 2023
jmank88
force-pushed
the
rm-libp2p
branch
15 times, most recently
from
22ae893 to
bcc22ed
Compare
jmank88
requested review from
a team,
jkongie,
samsondav and
connorwstein
as code owners
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
samsondav
approved these changes
Dec 4, 2023
samsondav
reviewed
Dec 4, 2023
| <!doctype html><html><head><meta charset="UTF-8"/><meta name="viewport" content="width=device-width,initial-scale=1"/><title>Operator UI</title><link rel="shortcut icon" href="https://smartcontract.imgix.net/chainlink.ico?auto=compress%2Cformat"/><link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" rel="stylesheet"/><link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet"/><link href="/favicon.ico" rel="shortcut icon" type="image/x-icon"/><title>Chainlink</title><script defer="defer" src="/assets/main.8f602c136d4004a835ee.js"></script></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> |
There was a problem hiding this comment.
I'm curious why the assets changed, or if they should even be in version control at all?
There was a problem hiding this comment.
There were problems with the fake assets that we used to embed (and then replace when actually building), so we decided to generate and commit the real ones instead. CI is already checking that generate is up to date, so piggy backing on that made it easy.
krehermann
approved these changes
Dec 4, 2023
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2708
Bump libocr, remove P2P Networking V1 and libp2p dependencies (~60!).
Requires: