-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/tracing-data: Trace data as artifact in CI #11113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhuie19
force-pushed
the
feature/tracing-data
branch
from
October 27, 2023 18:47
c783889
to
ec228af
Compare
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
I see that you haven't updated any README files. Would it make sense to do so? |
patrickhuie19
force-pushed
the
feature/tracing-data
branch
12 times, most recently
from
October 31, 2023 10:38
68c2548
to
0d92c29
Compare
patrickhuie19
force-pushed
the
feature/tracing-data
branch
14 times, most recently
from
November 7, 2023 15:42
8daa3a5
to
cbc62b9
Compare
patrickhuie19
force-pushed
the
feature/tracing-data
branch
from
November 8, 2023 23:11
2efb187
to
b1f5f0c
Compare
patrickhuie19
force-pushed
the
feature/tracing-data
branch
from
November 13, 2023 18:29
b1f5f0c
to
5aa138e
Compare
patrickhuie19
changed the title
feature/tracing-data: WIP
feature/tracing-data: Trace data as artifact in CI
Nov 13, 2023
patrickhuie19
requested review from
a team,
chainchad,
javuto,
jkongie,
jmank88 and
samsondav
as code owners
November 13, 2023 18:30
jmank88
previously approved these changes
Nov 13, 2023
krehermann
reviewed
Nov 13, 2023
patrickhuie19
force-pushed
the
feature/tracing-data
branch
from
November 13, 2023 21:59
2efc693
to
d289e0d
Compare
SonarQube Quality Gate |
krehermann
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouples lifecycle of tempo + grafana UI containers from the lifecycle of smoke test runs by collecting trace data as an artifact from test runs.