Update SimulatedBackendClient CallContext #11164
Conversation
EasterTheBunny
requested review from
samsondav and
prashantkumar1982
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
| return common.HexToAddress(v), nil | ||
| case *big.Int: | ||
| return common.BigToAddress(v), nil |
There was a problem hiding this comment.
Are there variants that return errors instead of failing silently?
There was a problem hiding this comment.
So far, the way it is used in tests, no. And it shouldn't fail silently. Everywhere this function is used will panic if it can't handle the value type. It's not ideal, but the way this is mainly used is in unit testing. So if it fails, the unit tests will fail.
There was a problem hiding this comment.
The Hex/BigToAddress funcs silently accept invalid values that could be difficult to debug from an indirect failure. Why don't we use IsHexAddress?
And could check for big.Int > 0 and b.Bytes() <=20?
There was a problem hiding this comment.
Ahh. Ok. I'll give that a Go...
EasterTheBunny
force-pushed
the
AUTO-7045/update-simulated-backend-client-callcontext
branch
from
ef51143 to
458c50e
Compare
| default: | ||
| // panic("not implemented") |
The function `CallContext` has different supported contract function calls than `BatchCallContext` even though the latter is simply a batch version of the former. This commit makes the two functions match both in the supported calls, but also in the validation and execution of those calls.
Use suggestion on default address returned on error. Co-authored-by: Jordan Krage <[email protected]>
…simulated backend client
EasterTheBunny
force-pushed
the
AUTO-7045/update-simulated-backend-client-callcontext
branch
from
2b2cf36 to
d38e967
Compare
|
SonarQube Quality Gate
|
EasterTheBunny
deleted the
AUTO-7045/update-simulated-backend-client-callcontext
branch
The function
CallContexthas different supported contract function calls thanBatchCallContexteven though the latter is simply a batch version of the former.This commit makes the two functions match both in the supported calls, but also in the validation and execution of those calls.