Remove Mercury's Notify ConfigTracker implementation #11171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
krehermann
force-pushed
the
poc/mercury-config-polling
branch
from
8e30adc to
475270a
Compare
krehermann
changed the title
|
SonarQube Quality Gate
|
krehermann
requested review from
samsondav,
sdrug and
martin-cll
as code owners
jmank88
approved these changes
Nov 8, 2023
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/MERC-2328
This change removes the Notify implementation of the mercury config tracker. The effect is that the builtin libocr polling will govern the refresh rate for configuration changes. The lowest this value can be is 15 seconds.
I have taken the liberty to make the change. One thing that needs to be considered before merging is how this change will interact with existing deployments. Since the poll rate for libocr is a job configuration value, and that value has been shortcircuited until this point, there is a risk that some jobs are poorly configured. We would want to ensure that this change is accompanied by check that all job definitions set the config poll interval to
15s