-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work to add an in-memory layer on top of the TxStore #11190
Closed
Closed
Changes from 11 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c53bb4c
initial commit for inmemory implementation
poopoothegorilla b75d260
some cleanup
poopoothegorilla 41a572d
Merge branch 'develop' into jtw/initial-in-memory-work
poopoothegorilla 3dde323
fix tests
poopoothegorilla 201a2dd
add some functions for the in memory store
poopoothegorilla 0c1d6cf
Merge branch 'develop' into jtw/initial-in-memory-work
poopoothegorilla b565d45
implement a few more methods for the in memory store
poopoothegorilla faf670f
some clean up
poopoothegorilla 178b0f0
add check for inprogress txn
poopoothegorilla fe25a26
make some changes to testing
poopoothegorilla a0ac2a3
reorganize tests
poopoothegorilla a28aa80
start initialization function; add priority queue system; change stor…
poopoothegorilla e2f3a87
add initialization to address state
poopoothegorilla 91bea75
change loops to not use range
poopoothegorilla 5314284
clean up idempotency key location
poopoothegorilla 5a908be
add find latest sequence
poopoothegorilla 9872283
remove FindLatestSequence from persistent interface
poopoothegorilla df5e946
add UnconfirmedTransactions to TxSoreWebApi
poopoothegorilla fcb9021
Merge branch 'develop' into jtw/initial-in-memory-work
poopoothegorilla 5d78868
address comments
poopoothegorilla a0a1a79
fix tests
poopoothegorilla 89d1056
fix bug in tests
poopoothegorilla 3663bd0
run go generate
poopoothegorilla 17cd10d
Merge branch 'develop' into jtw/initial-in-memory-work
poopoothegorilla 54b7ecc
address comment
poopoothegorilla f8e0175
update inmemory store to implement txstore interface
poopoothegorilla df1a11a
cleanup tests
poopoothegorilla 5452d02
Merge branch 'develop' into jtw/initial-in-memory-work
poopoothegorilla 5f0f6da
Merge branch 'develop' into jtw/initial-in-memory-work
poopoothegorilla f24eea7
add deepcopy
poopoothegorilla 325fb12
remove testing since this will be in future work
poopoothegorilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels weird to force users of txStore to check for two different error, that actually mean the same. Won't it be easier to return sql.ErrNoRows from in memory storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to get rid of the reliance on sql.ErrNoRows so this is the first step. relying on it forces us to be dependent on the sql pkg... i think we should use our own error types for it so we can make this less dependent