[TT-524] Separate Live Testnet Tests #11196
Conversation
kalverra
requested review from
a team,
chainchad,
javuto,
jkongie,
jmank88 and
samsondav
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
| ARBITRUM_GOERLI_HTTP_URLS: ${{ secrets.QA_ARBITRUM_GOERLI_HTTP_URLS }} | ||
|
|
||
| jobs: | ||
| build-chainlink: |
There was a problem hiding this comment.
I think this is duplicated between the two workflows now. We need to either move it to an action now or make a ticket to do so in the near future so we don't have to update multiple places.
There was a problem hiding this comment.
Definitely duplicated, I can move it into a shared action. My other concern with it (which I wanted to test out after merge, but maybe you know) is that often, both this and the simulated workflow will run in tandem. They're going to duplicate effort on this step, building the same image, which is annoying but can be lived with if need be. The other fear I had: will they somehow conflict with each other? 1 builds the image first and uploads, then the second tries to upload but errors?
There was a problem hiding this comment.
You can add -live to the name of the image pushed if it is an issue. I need to look into if the logic to use a builder workflow that these would wait on works better now than it did a couple years ago when I last played with it. We have a third build that happens as well so it would be nice to bring them all together. I will make a ticket for this.
|
SonarQube Quality Gate
|
This will help organize our integration test workflow which is getting bloated, and pave the way for more complex live testnet tests.