[TT-500][TT-682]Add build and lint to integration-tests #11221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
tateexon
force-pushed
the
TT-653-Migrate-CTF-Packages-To-CTF
branch
from
1994038 to
50b2d40
Compare
tateexon
commented
Nov 7, 2023
Tofel
reviewed
Nov 8, 2023
| @@ -18,35 +17,35 @@ import ( | |||
| "github.com/ethereum/go-ethereum/common" | |||
| geth_types "github.com/ethereum/go-ethereum/core/types" | |||
| "github.com/rs/zerolog" | |||
| "github.com/smartcontractkit/wasp" | |||
|
|
|||
There was a problem hiding this comment.
btw. maybe that whole folder's content should be located in integration-tests/actions to make it more consistent with existing structure?
There was a problem hiding this comment.
Out of the scope of this PR but something we can definitely look into doing.
jmank88
reviewed
Nov 8, 2023
jmank88
reviewed
Nov 8, 2023
jmank88
reviewed
Nov 8, 2023
jmank88
reviewed
Nov 8, 2023
jmank88
reviewed
Nov 8, 2023
tateexon
requested review from
chainchad,
javuto,
jkongie and
samsondav
as code owners
…ontext tied to the test.
tateexon
changed the title
kalverra
approved these changes
Nov 13, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covers TT-500 and TT-682