[DO NOT MERGE] Log provider: update scaling parameters #11253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
infiloop2
reviewed
Nov 27, 2023
| // MaxPayloads / 1 = 500 | ||
| // 2. worst case (all logs are for the same upkeep) | ||
| // MaxPayloads / MaxPayloadsPerUpkeep = 100 | ||
| MaxPayloads = 500 |
There was a problem hiding this comment.
We don't know whether attached RPCs to NOPs can handle these number of payloads per second yet
amirylm
changed the title
- set `MaxPayloads` to 500 (was 100) - separate parameters for provider/recoverer
amirylm
force-pushed
the
AUTO-7207-log-provider-increase-scaling-parameters
branch
from
e3d1906 to
261153d
Compare
|
SonarQube Quality Gate
|
amirylm
deleted the
AUTO-7207-log-provider-increase-scaling-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating scaling parameters of log provider, to increase the throughput of event logs that we are able to process:
MaxPayloadswas set to 500 (was 100)maxLogsPerBlockwas set to 8192 (was 1024)In addition, parameters for provider and recoverer are now separated to avoid coupling.