Create a codec entry with from args, allowing us to do type checking and to have structs to use with abi.Arguments's Pack function #11302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
nolag
force-pushed
the
rtinianov_parse_types
branch
from
985619a to
563b404
Compare
nolag
force-pushed
the
rtinianov_parse_types
branch
from
563b404 to
917ecec
Compare
jmank88
reviewed
Nov 20, 2023
nolag
force-pushed
the
rtinianov_evm_types
branch
2 times, most recently
from
69452ff to
63087bc
Compare
nolag
force-pushed
the
rtinianov_parse_types
branch
from
8002eab to
0389024
Compare
nolag
force-pushed
the
rtinianov_evm_types
branch
2 times, most recently
from
727b75c to
fa2b04f
Compare
nolag
requested review from
krehermann,
a team,
bolekk,
justinkaseman and
KuphJr
nolag
force-pushed
the
rtinianov_evm_types
branch
from
fa2b04f to
a97bf2e
Compare
Base automatically changed from
rtinianov_evm_types
to
BCF-2612-ChainReader-Next
November 27, 2023 19:06
nolag
force-pushed
the
rtinianov_parse_types
branch
from
0389024 to
cd92e54
Compare
…and to have structs to use with abi.Arguments's Pack function
nolag
force-pushed
the
rtinianov_parse_types
branch
from
cd92e54 to
17fe123
Compare
|
SonarQube Quality Gate
|
jmank88
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.