[Functions] Heartbeat request support in Gateway handlers #11345

bolekk · 2023-11-20T19:07:33Z

Functions Handler

add a new method "heartbeat"
add a configurable list of allowed heartbeat senders
collect results from first F+1 nodes and send back in raw form

Connector Handler

asynchronously forward requests to Listener and cache results
run a loop to collect OCR reports from Offchain Transmitter

Listener

add Timestamp field and validate it

github-actions · 2023-11-20T19:07:51Z

I see that you haven't updated any README files. Would it make sense to do so?

core/services/functions/connector_handler.go

pinebit · 2023-11-21T18:01:23Z

core/services/functions/connector_handler.go

+		return
+	}
+
+	internalId := InternalId(fromAddr.Bytes(), request.RequestId)


If I get this right, the only purpose of this "internal ID" is to make it the key to map.
However, you could simply make the key to be a value struct,

type heartbeatRequestKey struct { sender []byte requestId RequestID }

and then this struct can be directly used by map which will does hashing internally.
This would look much clearer to me.

We still need to have a single ID for request processing in the core node.

Can't it be just RequestID?

No because in the offchain scenario, RequestID is chosen by a user so we can't guarantee global uniqueness.

justinkaseman · 2023-11-21T18:52:19Z

core/services/functions/connector_handler.go

+		return
+	}
+
+	internalId := InternalId(fromAddr.Bytes(), request.RequestId)


Is the idea that request.RequestId will be generated in the same way that the contracts generate request ids?

No, not at all. Request ID in the offchain heartbeat request is generated by the user. To guarantee global uniqueness, we need to combine it with user address.

core/services/functions/listener.go

core/services/functions/request.go

1. Functions Handler - add a new method "heartbeat" - add a configurable list of allowed heartbeat senders - collect results from first F+1 nodes and send back in raw form 2. Connector Handler - asynchronously forward requests to Listener and cache results - run a loop to collect OCR reports from Offchain Transmitter 3. Listener - add Timestampi field and validate it

cl-sonarqube-production · 2023-11-27T15:59:26Z

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

83.3% Coverage
0.0% Duplication

1. Functions Handler - add a new method "heartbeat" - add a configurable list of allowed heartbeat senders - collect results from first F+1 nodes and send back in raw form 2. Connector Handler - asynchronously forward requests to Listener and cache results - run a loop to collect OCR reports from Offchain Transmitter 3. Listener - add Timestampi field and validate it

bolekk force-pushed the feature/FUN-1076-heartbeats-gateway branch 2 times, most recently from 893696c to 2ac4bfc Compare November 20, 2023 19:57

bolekk marked this pull request as ready for review November 20, 2023 20:20

bolekk requested a review from a team as a code owner November 20, 2023 20:20