Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use servicetest.Run & RunHealthy #11354

Merged
merged 1 commit into from
Dec 8, 2023
Merged

use servicetest.Run & RunHealthy #11354

merged 1 commit into from
Dec 8, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 21, 2023 •
edited
Loading

@jmank88 jmank88 mentioned this pull request Nov 21, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the common-servicetest branch 8 times, most recently from e3f173d to b7ddd2d Compare December 3, 2023 12:51
@jmank88 jmank88 force-pushed the common-servicetest branch 3 times, most recently from 0f80ae2 to d52d905 Compare December 6, 2023 17:52
@jmank88 jmank88 mentioned this pull request Dec 6, 2023
Merged
@jmank88 jmank88 force-pushed the common-servicetest branch 2 times, most recently from 1cc8add to 170b766 Compare December 6, 2023 19:55
@jmank88 jmank88 marked this pull request as ready for review December 6, 2023 20:17
@jmank88 jmank88 enabled auto-merge December 6, 2023 20:24
@jmank88 jmank88 force-pushed the common-servicetest branch from 170b766 to e1263cc Compare December 7, 2023 12:02
@jmank88 jmank88 requested a review from DylanTinianov December 7, 2023 16:26
@jmank88 jmank88 force-pushed the common-servicetest branch from e1263cc to 2ad9f84 Compare December 8, 2023 12:56
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 50.0% 50.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Dec 8, 2023
Merged via the queue into develop with commit d3f99e4 Dec 8, 2023
73 checks passed
@jmank88 jmank88 deleted the common-servicetest branch December 8, 2023 14:48
fbac pushed a commit that referenced this pull request Dec 14, 2023
@jmank88
use servicetest.Run & RunHealthy (#11354)
c2eb539
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@bolekk bolekk Awaiting requested review from bolekk

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@KuphJr KuphJr Awaiting requested review from KuphJr

@sdrug sdrug Awaiting requested review from sdrug

@martin-cll martin-cll Awaiting requested review from martin-cll

@connorwstein connorwstein Awaiting requested review from connorwstein

@PiotrTrzpil PiotrTrzpil Awaiting requested review from PiotrTrzpil

@reductionista reductionista Awaiting requested review from reductionista

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @samsondav