Soft migration to Generalize Multinode client for EVM BCI-2286 #11369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaidashenko
commented
Nov 22, 2023
dhaidashenko
commented
- Created feature flag that injects EVM client that is based on common/client/MultiNode
|
I see that you haven't updated any README files. Would it make sense to do so? |
dimriou
reviewed
Nov 23, 2023
dimriou
reviewed
Nov 23, 2023
dimriou
reviewed
Nov 23, 2023
dhaidashenko
requested review from
jkongie,
samsondav and
prashantkumar1982
as code owners
dimriou
previously approved these changes
Nov 23, 2023
# Conflicts: # core/chains/evm/client/chain_client.go # core/chains/evm/client/client.go # core/chains/evm/client/pool.go # core/chains/evm/client/send_only_node.go
jmank88
previously approved these changes
Nov 28, 2023
dimriou
reviewed
Nov 28, 2023
| func newEthClientFromChain(cfg evmconfig.NodePool, noNewHeadsThreshold time.Duration, lggr logger.Logger, chainID *big.Int, chainType commonconfig.ChainType, nodes []*toml.Node) (evmclient.Client, error) { | ||
| var primaries []evmclient.Node | ||
| var sendonlys []evmclient.SendOnlyNode | ||
| func newEthClientFromCfg(cfg evmconfig.NodePool, noNewHeadsThreshold time.Duration, lggr logger.Logger, chainID *big.Int, chainType commonconfig.ChainType, nodes []*toml.Node) evmclient.Client { |
There was a problem hiding this comment.
Is there a reason why we renamed this method?
There was a problem hiding this comment.
This method has no arguments with name or type chain (except chainID), so it felt weird to name it FromChain.
But I do not mind renaming it back to the newEthClientFromChain
|
SonarQube Quality Gate
|
jmank88
approved these changes
Nov 28, 2023
dimriou
approved these changes
Nov 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Allow switching to Generalized MultiNode EVM client via feature flag * test how linter reacts to deprecation * deprecate evm.client * address review comments * revert adding feature flag * create new client * fix call context * unwrapp CallContext args * deprecation msg improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.