Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCI-2151] Refactor prom reporter db API #11394

Merged
merged 19 commits into from
Nov 30, 2023
Merged

[BCI-2151] Refactor prom reporter db API #11394

merged 19 commits into from
Nov 30, 2023

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Nov 27, 2023 •
edited
Loading

Refactored prom reporter to use the txStore API instead of reading directly from the db.

@DylanTinianov DylanTinianov self-assigned this Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@DylanTinianov DylanTinianov marked this pull request as ready for review November 27, 2023 18:32
@DylanTinianov DylanTinianov changed the title [BCI-1501] Refactor prom reporter db API [BCI-2151] Refactor prom reporter db API Nov 27, 2023
amit-momin
amit-momin requested changes Nov 27, 2023
View reviewed changes
core/chains/evm/txmgr/evm_tx_store.go Outdated Show resolved Hide resolved
core/chains/evm/txmgr/evm_tx_store.go Outdated Show resolved Hide resolved
core/chains/evm/txmgr/evm_tx_store.go Outdated Show resolved Hide resolved
core/chains/evm/txmgr/evm_tx_store.go Outdated Show resolved Hide resolved
core/chains/evm/txmgr/evm_tx_store_test.go Outdated Show resolved Hide resolved
core/chains/evm/txmgr/evm_tx_store_test.go Outdated Show resolved Hide resolved
core/services/promreporter/prom_reporter.go Outdated Show resolved Hide resolved
core/services/chainlink/application.go Outdated Show resolved Hide resolved
prashantkumar1982
prashantkumar1982 reviewed Nov 28, 2023
View reviewed changes
core/chains/evm/txmgr/evm_tx_store.go Outdated Show resolved Hide resolved
core/services/promreporter/prom_reporter.go Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
amit-momin
amit-momin reviewed Nov 28, 2023
View reviewed changes
common/txmgr/txmgr.go Outdated Show resolved Hide resolved
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

89.4% 89.4% Coverage
0.0% 0.0% Duplication

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Nov 30, 2023
Merged via the queue into develop with commit c21f4ff Nov 30, 2023
102 of 122 checks passed
@prashantkumar1982 prashantkumar1982 deleted the BCI-2151-promreporter-txm-db branch November 30, 2023 20:52
fbac pushed a commit that referenced this pull request Dec 14, 2023
@DylanTinianov @prashantkumar1982
[BCI-2151] Refactor prom reporter db API (#11394)
2a216cb 
* Refactor prom reporter db API

* Add test case

* lint

* Use Txm from LegacyChainContainer

* Use legacyevm

* lint

* Use TXM chainID

* lint

---------

Co-authored-by: Prashant Yadav <[email protected]>
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@samsondav samsondav Awaiting requested review from samsondav

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @prashantkumar1982 @amit-momin