Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Mercury.TLS field CertPath for node communication with web servers + load balancers over TLS #11492

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Adding Mercury.TLS field CertPath for node communication with web servers + load balancers over TLS #11492

merged 2 commits into from
Jan 9, 2024

Conversation

patrickhuie19
Copy link
Contributor

No description provided.

@patrickhuie19 patrickhuie19 force-pushed the feature/transmission-key branch from 11e2f74 to 80faea9 Compare December 5, 2023 05:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@patrickhuie19 patrickhuie19 changed the title feature/transmission_key: adding Transmission.TLS field CertPath Adding Transmission.TLS field CertPath for node communication with web servers + load balancers over TLS Dec 5, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

patrickhuie19
patrickhuie19 commented Dec 11, 2023
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
samsondav
samsondav previously approved these changes Dec 11, 2023
View reviewed changes
jmank88
jmank88 reviewed Dec 11, 2023
View reviewed changes
core/config/app_config.go Outdated Show resolved Hide resolved
@patrickhuie19 patrickhuie19 force-pushed the feature/transmission-key branch 2 times, most recently from dccff56 to 33ee4ff Compare January 8, 2024 06:02
@patrickhuie19 patrickhuie19 changed the title Adding Transmission.TLS field CertPath for node communication with web servers + load balancers over TLS Adding Mercury.TLS field CertPath for node communication with web servers + load balancers over TLS Jan 8, 2024
@patrickhuie19 patrickhuie19 requested a review from jmank88 January 8, 2024 06:03
@patrickhuie19 patrickhuie19 marked this pull request as ready for review January 8, 2024 06:07
@patrickhuie19 patrickhuie19 force-pushed the feature/transmission-key branch from 33ee4ff to 0d9b265 Compare January 8, 2024 19:51
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@patrickhuie19 patrickhuie19 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into develop with commit 0f82c97 Jan 9, 2024
80 checks passed
@patrickhuie19 patrickhuie19 deleted the feature/transmission-key branch January 9, 2024 18:29
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
@snehaagni snehaagni mentioned this pull request Mar 21, 2024
Closed
@snehaagni snehaagni mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@samsondav samsondav samsondav left review comments

@jkongie jkongie Awaiting requested review from jkongie

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhuie19 @jmank88 @samsondav