Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support contract mapping #11532

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Support contract mapping #11532

merged 1 commit into from
Dec 12, 2023

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Dec 11, 2023

No description provided.

@nolag nolag requested a review from a team as a code owner December 11, 2023 01:00
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@nolag nolag force-pushed the rtinianov_multicontracttest branch 3 times, most recently from ff16e35 to 57d3e6d Compare December 11, 2023 14:37
ilija42
ilija42 requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly code nits

@nolag nolag force-pushed the rtinianov_multicontracttest branch from 57d3e6d to c75465f Compare December 12, 2023 15:48
@nolag nolag requested a review from ilija42 December 12, 2023 15:52
@nolag nolag force-pushed the rtinianov_multicontracttest branch from c75465f to 484354c Compare December 12, 2023 15:59
@nolag nolag force-pushed the rtinianov_multicontracttest branch from 484354c to f2beeb4 Compare December 12, 2023 16:38
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 59.7% 59.7% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

ilija42
ilija42 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, its a bit hard to see the changes when its force pushed into a single commit. Maybe do this after final approval, so its easier to re-review?

@nolag nolag merged commit 9f61865 into BCF-2612-ChainReader-Next Dec 12, 2023
82 of 84 checks passed
@nolag nolag deleted the rtinianov_multicontracttest branch December 12, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolag @ilija42