Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct references to TXM DB from external component tests #11538

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Remove direct references to TXM DB from external component tests #11538

merged 4 commits into from
Dec 14, 2023

Conversation

amit-momin
Copy link
Contributor

  • Expanded TxStore test functions to cover needed use cases for external components' tests
  • Replaced direct references to the TXM DB in external tests with new methods added to the TxStore

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@amit-momin amit-momin force-pushed the remove-txm-db-refs-in-tests branch 3 times, most recently from 0d14ce4 to 6af6e48 Compare December 11, 2023 23:12
@amit-momin amit-momin force-pushed the remove-txm-db-refs-in-tests branch from 6af6e48 to afa6f6d Compare December 11, 2023 23:39
@amit-momin amit-momin marked this pull request as ready for review December 11, 2023 23:49
prashantkumar1982
prashantkumar1982 previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

jmank88
jmank88 previously approved these changes Dec 12, 2023
View reviewed changes
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@amit-momin amit-momin dismissed stale reviews from prashantkumar1982 and jmank88 via aa7e7a7 December 14, 2023 21:11
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 14, 2023
Merged via the queue into develop with commit 7773d03 Dec 14, 2023
83 of 84 checks passed
@prashantkumar1982 prashantkumar1982 deleted the remove-txm-db-refs-in-tests branch December 14, 2023 22:44
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@jmank88 jmank88 jmank88 left review comments

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit-momin @jmank88 @prashantkumar1982