percentage premium for vrfv2plus with link discount #11644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jinhoonbang
commented
Dec 20, 2023
| weiPerUnitGas | ||
| ); | ||
| } | ||
|
|
||
| function _calculatePaymentAmountNative( | ||
| uint256 startGas, | ||
| uint256 gasAfterPaymentCalculation, | ||
| uint32 fulfillmentFlatFeePPM, | ||
| uint256 weiPerUnitGas | ||
| ) internal view returns (uint96) { | ||
| // Will return non-zero on chains that have this enabled | ||
| uint256 l1CostWei = ChainSpecificUtil._getCurrentTxL1GasFees(msg.data); | ||
| // calculate the payment without the premium | ||
| uint256 baseFeeWei = weiPerUnitGas * (gasAfterPaymentCalculation + startGas - gasleft()); | ||
| // calculate the flat fee in wei |
There was a problem hiding this comment.
TODO: change comment
|
SonarQube Quality Gate
|
jinhoonbang
commented
Dec 21, 2023
| uint8 nativePremiumPercentage; | ||
| // Discount percentage for link payment. Cannot exceed nativePremiumPercentage value. If nativePremiumPercentage is 15 and | ||
| // linkDiscountPercentage is 5, then the final premium is 10% premium of the total gas costs for link payment. | ||
| uint8 linkDiscountPercentage; |
There was a problem hiding this comment.
alternatively can be linkPremiumPercentage instead of discount percentage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.