Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service cleanup #11655

Merged
merged 1 commit into from
Dec 22, 2023
Merged

service cleanup #11655

merged 1 commit into from
Dec 22, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 22, 2023

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 marked this pull request as ready for review December 22, 2023 01:10
@jmank88 jmank88 requested review from a team, bolekk, justinkaseman and KuphJr as code owners December 22, 2023 01:10
@jmank88 jmank88 requested review from krehermann, patrickhuie19 and a team December 22, 2023 01:10
@jmank88 jmank88 enabled auto-merge December 22, 2023 01:12
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 33.3% 33.3% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Dec 22, 2023
Merged via the queue into develop with commit 3661f48 Dec 22, 2023
78 of 79 checks passed
@jmank88 jmank88 deleted the service-cleanup branch December 22, 2023 01:58
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@bolekk bolekk bolekk approved these changes

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@KuphJr KuphJr Awaiting requested review from KuphJr

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @bolekk @patrickhuie19